On 26 Nov 2014, at 22:13, Peter Maydell <peter.mayd...@linaro.org> wrote:
> Hmm. We have a workaround already for a similar thing in > include/sysemu/os-win32.h, > but that works by declaring a prototype rather than using a #define, and it's > guarded by defined(_WIN64). I wonder if some of those workarounds in that file > need to be guarded by more specific checks than just _WIN64... I reverted my patch and created another one based on your workaround, with the following changes: in os_win32.h: /* Declaration of ffs() is missing in MinGW's strings.h. */ #ifdef __MINGW32__ #define ffs __builtin_ffs #else int ffs(int i); #endif in qemu-common.h: #ifdef _WIN32 #include "sysemu/os-win32.h" #endif #ifdef __MINGW32__ #include "sysemu/os-win32.h" #endif with these two changes the build with MinGW-32 passes. --- another build procedure with MinGW-64 is considered; if successful, the steps will be described in the GNU ARM Eclipse wiki. --- however, not related to the above, the build shows tens, maybe hundreds of warnings, most of them -Wformat, but also many -Wformat-extra-args. perhaps someone with a good knowledge of the code could take a look at these warnings. regards, Liviu
