On 12/05/2014 03:08 AM, Max Reitz wrote: > Add an option to qmp_blockdev_change_medium() which allows changing the > read-only status of the block device whose medium is changed. > > Some drives do not have a inherently fixed read-only status; for > instance, floppy disks can be set read-only or writable independently of > the drive. Some users may find it useful to be able to therefore change > the read-only status of a block device when changing the medium. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > blockdev.c | 24 +++++++++++++++++++++++- > hmp.c | 2 +- > qapi/block-core.json | 24 +++++++++++++++++++++++- > qmp-commands.hx | 24 +++++++++++++++++++++++- > qmp.c | 3 ++- > 5 files changed, 72 insertions(+), 5 deletions(-)
Feels much nicer than v1 :)
> +2. Load a read-only medium into a writable drive
> +
> +-> { "execute": "blockdev-change-medium",
> + "arguments": { "device": "isa-fd0",
> + "filename": "/srv/images/ro.img",
> + "format": "raw",
> + "read-only": "retain" } }
> +
> +<- { "error":
> + { "class": "GenericError",
> + "desc": "Could not open '/srv/images/ro.img': Permission denied" } }
> +
> +-> { "execute": "blockdev-change-medium",
> + "arguments": { "device": "isa-fd0",
> + "filename": "/srv/images/ro.img",
> + "format": "raw",
> + "read-only": "ro" } }
> +
> +<- { "return": {} }
Nice example.
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
