On Mon, Dec 01, 2014 at 03:30:09PM -0500, John Snow wrote: > diff --git a/include/block/block.h b/include/block/block.h > index 066ded6..f180f93 100644 > --- a/include/block/block.h > +++ b/include/block/block.h > @@ -440,6 +440,8 @@ void bdrv_dirty_bitmap_make_anon(BlockDriverState *bs, > BdrvDirtyBitmap *bitmap); > void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap > *bitmap); > BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockDriverState *bs); > uint64_t bdrv_dbm_calc_def_granularity(BlockDriverState *bs); > +int64_t bdrv_dirty_bitmap_granularity(BlockDriverState *bs, > + BdrvDirtyBitmap *bitmap);
This looks weird now. The default granularity has uint64_t type but the actual granularity has int64_t. Please make them consistent.
pgpHmbIpEuyvW.pgp
Description: PGP signature