On Thu, Dec 11, 2014 at 12:33:35PM +0100, Gerd Hoffmann wrote: > Hi, > > > That's not a correct interpretation of the auth values - tls and x509 are > > not separate auth codes. VNC has one set of primary auth codes really > > > > none, vnc, vencrypt > > Well, the source code also has (see vnc_auth_name in ui/vnc.c): > > ra2, ra2ne, tight, ultra, tls, sasl
True, though most of those aren't actually implemented (only SASL is) > > If using the vencrypt option there are a number of sub-auth codes > > > > tls-none, tls-vnc, tls-plain, tls-sasl x509-none, x509-vnc, x509-plain, > > x509-sasl > > So better add a 'vencrypt-subauth' enum with this list? Yeah probably a good idea Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|