On 03/13/2010 04:55 AM, Edgar E. Iglesias wrote:
On Thu, Mar 11, 2010 at 04:48:43PM +0200, Avi Kivity wrote:
Signed-off-by: Avi Kivity<a...@redhat.com>
---
CODING_STYLE | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/CODING_STYLE b/CODING_STYLE
index a579cb1..92036f3 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -49,6 +49,9 @@ and is therefore likely to be changed.
Typedefs are used to eliminate the redundant 'struct' keyword. It is the
QEMU coding style.
+When wrapping standard library functions, use the prefix qemu_ to alert
+readers that they are seeing a wrapped version; otherwise avoid this prefix.
+
4. Block structure
Every indented statement is braced; even if the block contains just one
Not sure what "standard library functions" includes but I think the
qemu prefix should be allowed whenever one needs to wrap external
code blocks into qemu.
That was the intent.
I don't feel very strongly about this though. I can call my stuff
wrap_xxx if I need to :)
A downside of a formal coding style document is that people start
lawyering about it. Common sense can still be applied, if there is a
use case that is similar to what is described, surely qemu_ can still hold.
--
Do not meddle in the internals of kernels, for they are subtle and quick to
panic.
