On 2014/12/16 22:01, Peter Maydell wrote: > On 16 December 2014 at 09:22, <arei.gong...@huawei.com> wrote: >> From: root <root@ceth6.(none)> >> >> This is my first pull request as a submaintainer. Those patches just >> move boot order related code to bootdevice.c and add a Error **errp >> argument for corresponding functions so that it can propagate error messages >> to the caller. Please pull. > > This also seems to cause 'make check' to fail: > > TEST: tests/boot-order-test... (pid=16958) > /i386/boot-order/pc: > Broken pipe > FAIL > GTester: last random seed: R02S5702c094d31af53e45fffabed844705a > (pid=16973) > FAIL: tests/boot-order-test >
Oops, That's because of a typo in patch 2, 'once' -> 'order'. 'make check' should be executed before posting patches :( I apologize for any inconvenience caused during this process, and great thanks for your precise job. Regards, -Gonglei
