On Wed, Mar 17, 2010 at 09:44:05AM +0530, Amit Shah wrote:
> On (Tue) Mar 16 2010 [19:10:58], Michael S. Tsirkin wrote:
> >
> > diff --git a/hw/virtio.c b/hw/virtio.c
> > index 7c020a3..f54129f 100644
> > --- a/hw/virtio.c
> > +++ b/hw/virtio.c
> > @@ -73,6 +73,9 @@ struct VirtQueue
> > int inuse;
> > uint16_t vector;
> > void (*handle_output)(VirtIODevice *vdev, VirtQueue *vq);
> > + VirtIODevice *vdev;
> > + EventNotifier guest_notifier;
> > + EventNotifier host_notifier;
>
> Another thing that terribly confused me was this: in the vq struct you
> have guest_notifier and host_notifier of type EventNotifier and in the
> virtio binding structs you have guest_notifier and host_notifier which
> are function callbacks.
> Also, these vq->{guest_|host_}notifier assignments weren't easily found
> using grep because they're assigned by assigning a pointer value and
> initialising that pointer. Thanks to Juan for finding that for me :-)
>
> Amit
I've renamed them to set_xxx_notifier to avoid confusion.
> --
> http://log.amitshah.net/
