Am 15.02.2015 um 15:17 hat Hitoshi Mitake geschrieben: > At Fri, 13 Feb 2015 18:20:53 +0900, > Teruaki Ishizaki wrote: > > > > Previously, qemu block driver of sheepdog used hard-coded VDI object size. > > This patch enables users to handle VDI object size. > > > > When you start qemu, you don't need to specify additional command option. > > > > But when you create the VDI which doesn't have default object size > > with qemu-img command, you specify object_size option. > > > > If you want to create a VDI of 8MB object size, > > you need to specify following command option. > > > > # qemu-img create -o object_size=8M sheepdog:test1 100M > > > > In addition, when you don't specify qemu-img command option, > > a default value of sheepdog cluster is used for creating VDI. > > > > # qemu-img create sheepdog:test2 100M > > > > Signed-off-by: Teruaki Ishizaki <ishizaki.teru...@lab.ntt.co.jp> > > --- > > V5: > > - Change option from block_size_shift to object_size. > > - Change parse type to QEMU_OPT_SIZE. > > - Add operation to verify max VDI size for resizing. > > - Change to use 4MB object size with using old Sheepdog. > > > > V4: > > - Limit a read/write buffer size for creating a preallocated VDI. > > - Replace a parse function for the block_size_shift option. > > - Fix an error message. > > > > V3: > > - Delete the needless operation of buffer. > > - Delete the needless operations of request header. > > for SD_OP_GET_CLUSTER_DEFAULT. > > - Fix coding style problems. > > > > V2: > > - Fix coding style problem (white space). > > - Add members, store_policy and block_size_shift to struct SheepdogVdiReq. > > - Initialize request header to use block_size_shift specified by user. > > --- > > block/sheepdog.c | 155 > > ++++++++++++++++++++++++++++++++++++++------- > > include/block/block_int.h | 1 + > > 2 files changed, 134 insertions(+), 22 deletions(-) > > Looks good to me. > Acked-by: Hitoshi Mitake <mitake.hito...@lab.ntt.co.jp>
Thanks, applied to the block branch. Kevin
