> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 02/02/2015 13:42, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >> On 02/02/2015 13:28, Pavel Dovgaluk wrote: > >>>>>>> cpu->exception_index = EXCP_INTERRUPT; > >>>>>>> next_tb = 0; > >>>>>>> + qemu_notify_event(); > >>>>> > >>>>> Why is this needed? > >>> It is needed to wake up iothread in replay mode. > >>> Otherwise it waits for additional time and replay becomes too slow. > >> > >> What event (something from a timerlist?) is ready, that has not been > >> notified to the iothread yet? qemu_notify_event() should never be > >> needed in common case. It's probably missing somewhere else. > > > > I think in this case there are no events at all - just reading timers values > > that were made while recording. > > We have to replay these reads by waking iothread. > > I think the right place for this is in replay_read_next_clock then.
It doesn't fit. Log file is not read until all instructions are executed. And the next read from the file should be performed by iothread which should be notified and waked up. Pavel Dovgalyuk
