On Mon, Feb 16, 2015 at 9:30 AM, Alistair Francis <alistai...@gmail.com> wrote:
> On Mon, Feb 16, 2015 at 12:17 AM, Ryota Ozaki <ozaki.ry...@gmail.com> wrote:
>> Signed-off-by: Ryota Ozaki <ozaki.ry...@gmail.com>
>
> The title of your patch is incorrect, you specified A53 when you really mean
> A57
Definitely. I'm sorry for my fault (I found this problem when I was trying
A53 emulation...)
>
>> ---
>> target-arm/cpu64.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c
>> index 823c739..270bc2f 100644
>> --- a/target-arm/cpu64.c
>> +++ b/target-arm/cpu64.c
>> @@ -96,6 +96,7 @@ static void aarch64_a57_initfn(Object *obj)
>> {
>> ARMCPU *cpu = ARM_CPU(obj);
>>
>> + cpu->dtb_compatible = "arm,cortex-a57";
>
> What happens without this?
Recent Linux looks up the property and warns "Unknown CPU type"
if it doesn't exist. Not big deal, actually.
>
> Once the title is fixed:
>
> Reviewed-by: Alistair Francis <alistair.fran...@xilinx.com>
Thanks! I'm preparing a revised patch.
ozaki-r
>
>> set_feature(&cpu->env, ARM_FEATURE_V8);
>> set_feature(&cpu->env, ARM_FEATURE_VFP4);
>> set_feature(&cpu->env, ARM_FEATURE_NEON);
>> --
>> 2.3.0
>>
>>
