On Mon, Feb 16, 2015 at 5:16 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 16/02/2015 22:47, sfel...@gmail.com wrote: >> From: Scott Feldman <sfel...@gmail.com> >> >> Add QMP/HMP support for rocker devices. This is mostly for debugging >> purposes >> to see inside the device's tables and port configurations. Some examples: >> >> (qemu) info rocker sw1 >> name: sw1 >> id: 0x0000013512005452 >> ports: 4 > > I think CONFIG_ROCKER doesn't work as intended. It's not exported to C > files.
It's working fine. What do you think it broken? > I would just merge the other nine patches for 2.3. I disagree. qmp/hmp is very important to rocker. It would be nearly impossible to debug large/complicated networking setups without having a back-door view into the device. qmp/hmp are perfect for this. Since rocker's primary purpose is for development of OS support for traditional L2/L3 offloads as well as flow-based offloads, it is important to enable this debug tool. -scott
