On Thu, 03/12 08:22, Michael S. Tsirkin wrote: > On Thu, Mar 12, 2015 at 02:40:55PM +0800, Fam Zheng wrote: > > Currently we could leave PCI IRQ asserted even after reset, it is safer > > to clear it. > > > > In the case that a buggy driver has disabled MSI-X unintentially, we may > > have already injected IRQ in previous virtio_pci_notify, which will not > > be cleared by guest because it doesn't expect it (i.e. no irq handler). > > However the driver may eventually notice the unresponsiveness and reset > > the device, at that point, clearing the irq is meaningful. > > > > Signed-off-by: Fam Zheng <f...@redhat.com> > > I don't get it. interrupts are de-asserted > in pci core: > > static void pci_do_device_reset(PCIDevice *dev) > { > int r; > > pci_device_deassert_intx(dev); > > ... > } > > why isn't this sufficient?
Becuase it's not called by virtio_pci_reset. Fam