Anthony Liguori <anth...@codemonkey.ws> wrote: > On 03/31/2010 02:37 PM, Shahar Havivi wrote: >> On Wed, Mar 31, 2010 at 06:58:14PM +0200, Juan Quintela wrote: >> >>> Date: Wed, 31 Mar 2010 18:58:14 +0200 >>> From: Juan Quintela<quint...@redhat.com> >>> To: Markus Armbruster<arm...@redhat.com> >>> Cc: Shahar Havivi<shah...@redhat.com>, qemu-devel@nongnu.org >>> Subject: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' >>> and 'info keybaord' >>> >>> Markus Armbruster<arm...@redhat.com> wrote: >>> >>>> Juan Quintela<quint...@redhat.com> writes: >>>> >>>>> I still think that adding an "id" property as in markus proposal would >>>>> be neat. Otherwise I don't know how you are going to distinguish >>>>> between two keyboards with the same name. >>>>> >>>> If I understand the patch correctly (only time for a quick skim today), >>>> the keyboard receives a numeric ID when it is created, and keyboard_set >>>> identifies it by that ID. Yes, a user-defined ID would be nicer, and >>>> consistent with how similar things work. But the numeric ID isn't >>>> *wrong*, as far as I can see. >>>> >>> my problem is that if you add two keyboards of the same type, they will >>> receive random index (different ones), now you do info keyboard, and you >>> see two keyboard with the same names and different numbers, how do you >>> know which of the two given you want to choose? >>> >>> And no, I don't have magic bullet to make multimonitor/keyboard/mouse >>> behave as expected out of given them right id's. >>> >>> Later, Juan. >>> >> You right, this is a problem. >> As I see it id cannot be force to receive by the user right? >> > > This is already the case with the mouse. > > Ultimately, I don't think it's a useful problem to attempt to solve. > Why would there every be two keyboards of the same type (or two mice)?
I don't understand why somebody will want multiscreen+mouse+keyboard. Once told that, if having more than one of any of them, then it is better that keyboard_set /* * do_keyboard_set(): Set active keyboard * * Argument qdict contains * - "index": the keyboard index to set should take as a keyboard the string identifier and be done with that? Instead of all this bussines of numbering/renumbering during hot [un]plug? Later, Juan.
