On 27/03/2015 06:44, Fam Zheng wrote: > Based on the commit log that said memory_region_is_logging() only returns 0 or > (1 << DIRTY_MEMORY_VGA), the new code keeps the truth table. But I don't > understand why is DIRTY_MEMORY_MIGRATION excluded here and below?
Because DIRTY_MEMORY_MIGRATION is handled via the log_global_start/log_global_stop mechanism. The functions I'm patching here are called only through region_add and region_del, so they do not care about DIRTY_MEMORY_MIGRATION. The plan is to remove this special case: > This is the ugliest patch in the series. My long-term plan > is to get rid of the global start/stop hooks in the > MemoryListeners. but it is not trivial so it's better done in a different patch series. Paolo
