On 13 April 2015 at 04:01, Jason Wang <jasow...@redhat.com> wrote: > > > On Thu, Apr 9, 2015 at 9:32 PM, Thomas Huth <th...@redhat.com> wrote: >> >> Current QEMU crashes when specifying an illegal model with the >> "-net nic,model=xxx" option, e.g.: >> >> $ qemu-system-x86_64 -net nic,model=n/a >> qemu-system-x86_64: Unsupported NIC model: n/a
>> The problem is that pci_nic_init_nofail() does not check whether the err >> parameter from pci_nic_init has been set up and thus passes a NULL pointer >> to error_report_err(). Fix it by correctly checking the err parameter. >> >> Signed-off-by: Thomas Huth <th...@redhat.com> > Reviewed-by: Jason Wang <jasow...@redhat.com> Applied, thanks (with a 'pci:' subject prefix added). -- PMM
