On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Mandatory option is silly, and the error handling is missing: the > programs crash when -i isn't supplied. Make it an argument, and check > it properly. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > Makefile | 14 +++++++------- > scripts/qapi.py | 10 ++++------ > tests/Makefile | 8 ++++---- > 3 files changed, 15 insertions(+), 17 deletions(-)
Needs corresponding changes to docs/qapi-code-gen.txt (several examples use --input-file=...). > @@ -935,8 +932,9 @@ def parse_command_line(extra_options = "", > extra_long_options = []): > do_c = True > do_h = True > > - if len(args) != 0: > + if len(args) != 1: > print >>sys.stderr, "%s: too many arguments"% sys.argv[0] > sys.exit(1) Won't this report 'too many arguments' even for a missing argument? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
