Re: [Qemu-devel] [PATCH v13 10/12] qdev: check callback takes the property child as third argument

[Eric Auger]

On 04/29/2015 10:22 AM, Paolo Bonzini wrote:
> 
> 
> On 28/04/2015 18:51, Eric Auger wrote:
>> -    prop->check(obj, name, new_target, &local_err);
>> +    object_ref(new_target);
>> +    *child = new_target;
>> +
>> +    prop->check(obj, name, child, &local_err);
>>      if (local_err) {
>>          error_propagate(errp, local_err);
>> +        *child = old_target;
>> +        object_ref(new_target);
> 
> This should be an unref.

oups yes.

Thanks! Do I keep this series or do I revert to sysbus irq connect irq
temporary patch as per Peter's last email?

Eric
> 
> Paolo
> 
>>          return;
>>      }
>>  
>> -    object_ref(new_target);
>> -    *child = new_target;
>>      object_unref(old_target);