Peter Krempa <pkre...@redhat.com> writes: > The 'socket_optslist' structure does not contain the 'localaddr' and > 'localport' options that are parsed in case you are creating a > 'connect' type UDP character device. > > I've noticed it happening after commit f43e47dbf6de24db20ec9b588bb6cc762 > made qemu abort() after seeing the invalid option. > > A minimal reproducer for the case is: > $ qemu-system-x86_64 -chardev > udp,id=charrng0,host=127.0.0.1,port=1234,localaddr=,localport=1234 > qemu-system-x86_64: -chardev > udp,id=charrng0,host=127.0.0.1,port=1234,localaddr=,localport=1234: Invalid > parameter 'localaddr' > Aborted (core dumped) > > Prior to the commit mentioned above the error would be printed but the > value for localaddr and localport was simply ignored. I did not go > trhough the code to find out when it was broken.
s/trhough/through/ Perhaps this can be touched up on commit. > > Add the two fields so that the options can again be parsed correctly and > qemu doesn't abort(). > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1220252 > > Signed-off-by: Peter Krempa <pkre...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> File has no maintainer. Adding qemu-trivial. Reviewed-by: Markus Armbruster <arm...@redhat.com>
