On 05/28/2015 06:21 AM, Markus Armbruster wrote: > When the argument is non-zero, qemu_opt_foreach() stops on callback > returning non-zero, and returns that value. > > When the argument is zero, it doesn't stop, and returns the callback's > value from the last iteration. > > The two callers that pass zero could just as well pass one: > > * qemu_spice_init()'s callback add_channel() either returns zero or > exit()s. > > * config_write_opts()'s callback config_write_opt() always returns > zero. > > Drop the parameter, and always stop. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > ---
> +++ b/net/vhost-user.c
> @@ -185,7 +185,7 @@ static CharDriverState *net_vhost_parse_chardev(const
> NetdevVhostUserOptions *op
>
> /* inspect chardev opts */
> memset(&props, 0, sizeof(props));
> - if (qemu_opt_foreach(chr->opts, net_vhost_chardev_opts, &props, true) !=
> 0) {
> + if (qemu_opt_foreach(chr->opts, net_vhost_chardev_opts, &props)) {
Another case of confusion on 'int' vs. 'bool' gone. Good riddance!
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
