On Mon, June 1, 2015 6:05 am, Paolo Bonzini wrote:
>
>
> On 31/05/2015 00:04, Paulo Alcantara wrote:
>> + case TCO_RLD:
>> + tr->timeouts_no = 0;
>> + if (can_start_tco_timer(tr)) {
>> + tr->tco.rld = tr->tco.tmr;
>> + tco_timer_reload(tr);
>> + } else {
>> + tr->tco.rld = val;
>
> Please mask out bits outside TCO_RLD_MASK here, same as you do for
> TCO1_STS_MASK and friends.
OK.
>> + tr->tco.cnt1 = tr->tco.cnt1 & TCO_LOCK ? val | TCO_LOCK : val;
>
> Since you have to respin, you can do:
>
> tr->tco.cnt1 = val | (tr->tco.cnt1 & TCO_LOCK);
OK.
>
> Otherwise looks good to me.
>
> CCing the maintainer.
OK. Sorry for not CCing him earlier.
Thanks,
Paulo
--
Paulo Alcantara, C.E.S.A.R
Speaking for myself only.
