On Fri, May 29, 2015 at 03:29:57PM +0200, Alberto Garcia wrote: > On Fri 29 May 2015 02:32:45 PM CEST, Stefan Hajnoczi <stefa...@gmail.com> > wrote: > > >> def setUp(self): > >> - self.vm = iotests.VM().add_drive(self.test_img) > >> + self.vm = iotests.VM() > >> + for i in range(0, self.max_drives): > >> + self.vm.add_drive(self.test_img) > > > > Unique files are required, it's not safe to write to open the same > > image file for writing multiple times. > > But there's no file here, self.test_img is null-aio://
You are right. ThrottleTestCase is only used in this file so there's little danger of setUp() getting called with actual files. Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
pgpT4vxd226LA.pgp
Description: PGP signature
