> On 06 Jun 2015, at 01:54, Peter Maydell <peter.mayd...@linaro.org> wrote: > > On 5 June 2015 at 22:11, Liviu Ionescu <i...@livius.net> wrote: >> >>> On 05 Jun 2015, at 23:09, Leon Alrae <leon.al...@imgtec.com> wrote: >>> ... how the >>> TARGET_SYS_GET_CMDLINE should behave if cmdline is not available, >>> whether should return -1 or pass an empty string to the guest. >> >> for consistency I would suggest to return -1 for all cases that do >> not return a legal cmdline. > > The existing linux-user implementation of this semihosting > call handles this case by returning the empty string, so > consistency suggests following that in the equivalent > softmmu case.
in this case it doesn't make any major difference, the application should accommodate both cases, but, as a general comment, if one case is broken/poorly implemented, for the sake of consistency I would not rush to make all others broken too, but I would first try to find a solution to fix/improve them all. regards, Liviu
