-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
On 06/11/2015 09:03 AM, Stefan Hajnoczi wrote: > On Thu, Jun 11, 2015 at 01:19:24PM +0300, Vladimir > Sementsov-Ogievskiy wrote: >> On 10.06.2015 16:24, Stefan Hajnoczi wrote: >>> On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir >>> Sementsov-Ogievskiy wrote: >>>> On 09.06.2015 20:03, Stefan Hajnoczi wrote: >>>>> On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir >>>>> Sementsov-Ogievskiy wrote: >>>>>> @@ -166,6 +167,19 @@ the header extension data. Each >>>>>> entry look like this: terminated if it has full length) >>>>>> +== Dirty bitmaps == + +Dirty bitmaps is an optional >>>>>> header extension. It provides a possibility of +storing >>>>>> dirty bitmaps in qcow2 image. The fields are: + + >>>>>> 0 - 3: nb_dirty_bitmaps + Number of >>>>>> dirty bitmaps contained in the image >>>>> Is there a maximum? >>>> hmm. any proposals for this? >>> 65535 seems practical. >> >> So, you suggest to reduce this field width to 2b? And additional >> 2 bytes reserved field, to achieve 8b-alignment? > > No, I would leave it 32-bit but impose a little (which can be > increased later if necessary). That's how nb_snapshots works too. > Doesn't the code already limit the number of bitmaps via +#define QCOW_MAX_DIRTY_BITMAPS 65536, from patch 2? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVebWLAAoJEH3vgQaq/DkOJCYP/jUSJT+jhb3+GvAtddCssyYR u1BHZacXyTsDTwX4WDZQ5eGEZJZeSwu7++w5N+m+62yDxervarfEE0G/nuGRSNWx 0zYF0RrlYZFdDqed18rgXJJjCtNo1jp67ojk+xpEBUMx9cgFa6s+BTkrY0h+4hiO V3mvU0H1+8by1Ss5lvziKCHdrksGyBIS4gw+WZNshdOc46/nBZfSlh6CWmtOO/5S XZwXLKE7QMJMzigdcLJBOlymRwnF094Myklf8fZQILgbdoHoKhEEj9gVWkSpoNk9 FkMDDS1qN5vtYy5Ehzwy9QpbsN5ZEhuHoj5N8k0vDfFHgB9KKvOChvxf2lVhgbz7 fvGpqUb4eEdTvRno9V+8KoEcs99JXLvhed8LrfcZzq05WKbLeAdXYj18QrDw8pdY Fl4kV5Ca4dpvDAcNZDlCKERv+STLh56hYXEYtjzNEXL+ryQwUyHetY/M6Qodq0j2 FtJq21aj68vEOovQQcX2QxqRxkPzDEvNPbM+phBOh2FjQkbvB6I5bs/ueloyi2q9 UtXWhR6ImUgA6LN25OIc6GS9xYJsFiQlLh1uI/bJoDEpQvVnMojAXE7SohyTya89 2+HIGJsdkbBZsc4SN1INqcsRCeN1at8KiwdIbAijrciF9WIsv0kUEvCvmA93UVYp s2Os9g5QgMXrK1icCK5J =CIuZ -----END PGP SIGNATURE-----