Hi, Am 24.06.2015 um 04:31 schrieb Peter Crosthwaite: > Hi All, > > I'm moving towards the goal of having no core code usages of ENV_GET_CPU. > This has two advantages: > > 1: It means we are closer to common-obj'ing core code like exec.c, cpus.c > and friends. > 2: Multi arch is easier if ENV_GET_CPU() stays arch specific. It means I > don't need those patches where I reorder the env within the arch specific > CPUState. This allows continuing placement of arch specifics before the > env in the CPU container (which has TCG perf advantages). > > Due to point 1, I'm sending this ahead as I think it has standalone value, > rather than send as part of multi-arch.
Thanks for rebasing and combining this so handily, rebased onto qom-cpu with the dtc change stripped and a few massages to the messages: https://github.com/afaerber/qemu-cpu/commits/qom-cpu I considered modifying the ppc patch to have a local CPUState variable for the future, but left it as is for now. Most changes seemed mechanical. Alex gave a go-ahead; a few CCs haven't replied yet, please speak up within the next few days if we should wait (in particular Paolo and Riku). I still need to test on BSD - if someone has a Tested-by there that would be helpful. Regards, Andreas > Bharata B Rao (3): > cpus: Add Error argument to cpu_exec_init() > cpus: Convert cpu_index into a bitmap > ppc: Move cpu_exec_init() call to realize function > > Peter Crosthwaite (4): > translate-all: Change tb_flush() env argument to cpu > gdbserver: _fork: Change fn to accept cpu instead of env > cpus: Change tcg_cpu_exec() arg to cpu, not env > cpus: Change exec_init() arg to cpu, not env > > bsd-user/main.c | 2 +- > cpus.c | 7 +++-- > dtc | 2 +- > exec.c | 63 > ++++++++++++++++++++++++++++++++++++++------- > gdbstub.c | 9 +++---- > include/exec/exec-all.h | 4 +-- > include/exec/gdbstub.h | 2 +- > include/qom/cpu.h | 1 + > linux-user/main.c | 2 +- > linux-user/signal.c | 2 +- > qom/cpu.c | 7 +++++ > target-alpha/cpu.c | 2 +- > target-alpha/sys_helper.c | 2 +- > target-arm/cpu.c | 2 +- > target-cris/cpu.c | 2 +- > target-i386/cpu.c | 2 +- > target-i386/translate.c | 2 +- > target-lm32/cpu.c | 2 +- > target-m68k/cpu.c | 2 +- > target-microblaze/cpu.c | 2 +- > target-mips/cpu.c | 2 +- > target-moxie/cpu.c | 2 +- > target-openrisc/cpu.c | 2 +- > target-ppc/translate_init.c | 9 +++++-- > target-s390x/cpu.c | 2 +- > target-sh4/cpu.c | 2 +- > target-sparc/cpu.c | 2 +- > target-tricore/cpu.c | 2 +- > target-unicore32/cpu.c | 2 +- > target-xtensa/cpu.c | 2 +- > translate-all.c | 6 ++--- > 31 files changed, 101 insertions(+), 51 deletions(-) > -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)
