On Wed, Jul 01, 2015 at 12:15:09PM +0100, Peter Maydell wrote: > On 1 July 2015 at 05:20, David Gibson <da...@gibson.dropbear.id.au> wrote: > > On Mon, Jun 29, 2015 at 11:35:23AM +0100, Peter Maydell wrote: > >> A quick grep suggests you can knock arm, moxie, sh4 > >> and sh4eb off your list of things with CONFIG_SERIAL_ISA > >> (no hits for ISABus). > > > > I'll remove moxie, sh4 and sh4eb in my next spin. > > > > I'm not so comfortable about ARM. I get the impression that there are > > so many x86 people now working in the ARM space, that it wouldn't > > surprise me at all if some vendors go and stick legacy stuff on > > there. So I'd prefer to leave it to the ARM people themselves to turn > > it off if I'm wrong. > > I'm an ARM person :-) > > I'm happy to turn ISA off for ARM, except for the case of > generic PCI-to-ISA devices which IIRC you're handling by > having pci.mak set CONFIG_ISA ? > > (In practice that means ARM will still compile in the ISA > code, but hey.)
So that makes sense for the patch in this series which allows
deconfiguration of the ISA bus itself. But this patch is just about
ISA serial ports - given that ARM does have ISA for now, and will
still be able to with a bridge it seems odd to disable ISA serial
specifically.
Come to think of it, the same applies to SH4, since it has PCI. So
I've put SERIAL_ISA back in for SH4, and updated the commit message to
explain that for now I'm only taking out SERIAL_ISA support for things
that clearly have neither ISA nor PCI support.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgppG5ipCt_rw.pgp
Description: PGP signature
