On Sat, May 01, 2010 at 10:38:51PM -0400, Kevin O'Connor wrote: > Date: Sat, 1 May 2010 22:38:51 -0400 > From: Kevin O'Connor <ke...@koconnor.net> > To: qemu-devel@nongnu.org, seab...@seabios.org > Cc: > Subject: [Qemu-devel] [PATCH] Fix qemu mouse Set_Protocol behavior > > The QEMU USB mouse claims to support the "boot" protocol > (bInterfaceSubClass is 1). However, the mouse rejects the > Set_Protocol command. > > The qemu mouse does support the "boot" protocol specification, so a > simple fix is to just enable the Set_Portocol request. > > -Kevin Isn't it true for the USB_TABLET as well?
Shahar. > > > --- a/hw/usb-hid.c > +++ b/hw/usb-hid.c > @@ -790,13 +790,13 @@ static int usb_hid_handle_control(USBDevice *dev, int > request, int value, > goto fail; > break; > case GET_PROTOCOL: > - if (s->kind != USB_KEYBOARD) > + if (s->kind != USB_KEYBOARD && s->kind != USB_MOUSE) > goto fail; > ret = 1; > data[0] = s->protocol; > break; > case SET_PROTOCOL: > - if (s->kind != USB_KEYBOARD) > + if (s->kind != USB_KEYBOARD && s->kind != USB_MOUSE) > goto fail; > ret = 0; > s->protocol = value; > >
