On (Mon) 13 Jul 2015 [13:02:09], Juan Quintela wrote:

> > +    /* We're expecting a
> > +     *    Version (0)
> > +     *    a RAM ID string (length byte, name, 0 term)
> > +     *    then at least 1 16 byte chunk
> > +    */
> > +    if (len < 20) { 1 +
> 
>        1+1+1+1+2*8
> 
> Humm, thinking about it, .... why are we not needing a length field of
> number of entries?

hm, yea.

> > +        error_report("CMD_POSTCOPY_RAM_DISCARD invalid length (%d)", len);
> > +        return -1;
> > +    }
> > +
> > +    tmp = qemu_get_byte(mis->file);
> > +    if (tmp != 0) {
> 
> I think that a constant telling POSTCOPY_VERSION0 or whatever?

agreed.

                Amit

Reply via email to