The ICH6 AHCI implementation submitted by Chong is an all-in-one attempt (ahci.c). It includes all needed parts of the ICH6, AHCI, SATA and ATA specification. The code in hw/ide/* on the other hand is split (or could be split) into smaller parts like port based and bus master access, IDE and ATA core. I think it might be reasonable to split ahci.c into ICH6, AHCI and SATA parts and strip the limited ATA support and reuse it from the ide core. This would give us something like the following:
hw/ide/piix.c (PIIX3 and PIIX4) hw/ide/pci.c and core.c (IDE, BM) hw/ata-core.c (ATA) hw/sata/ich6.c (ICH6) hw/sata-core.c (SATA) hw/ahci-core.c (AHCI) Should this be a goal or am i over-engineering here? Sebastian
