On 03/08/2015 17:02, Paolo Bonzini wrote: > > > On 03/08/2015 16:46, Richard W.M. Jones wrote: >>>> I'm wondering if a 33 Mhz clock is 33000000 Hz or 33333333 Hz ? >> From the datasheet (chapter 16): >> >> https://www-ssl.intel.com/content/www/us/en/chipsets/6300esb-io-controller-hub-datasheet.html >> >> it says "33 MHz clock (30 ns clock ticks)" which is contradictory. > > I found that the spec allows for any speed up to 33333333 Hz (30 ns > cycle), so both are okay. However, at least hw/net/rtl8139.c assumes > it's 33000000 Hz, so it's nice to be consistent.
So, do you want I resend a patch with "1000 / 33" instead ? We can also update hw/net/rtl8139.c to replace "muldiv64(X, get_ticks_per_sec(), 33000000)" by "X * 30" ? Laurent
