On Mon, Aug 10, 2015 at 02:15:41PM +0100, Stefan Hajnoczi wrote: > The -msg timestamp=on option prepends a timestamp to error messages. > This is useful on stderr where it allows users to identify when an error > was raised. > > Timestamps do not make sense on the monitor since error_report() is > called in response to a synchronous monitor command and the user already > knows "when" the command was issued. Additionally, the rest of the > monitor conversation lacks timestamps so the error timestamp cannot be > correlated with other activity. > > Only prepend timestamps on stderr. This fixes libvirt's 'drive_del' > processing, which did not expect a timestamp. Other QEMU monitor > clients are probably equally confused by timestamps on monitor error > messages. > > Cc: Markus Armbruster <arm...@redhat.com> > Cc: Seiji Aguchi <seiji.agu...@hds.com> > Cc: Frank Schreuder <fschreu...@transip.nl> > Cc: Daniel P. Berrange <berra...@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > util/qemu-error.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
