On 05/12/10 22:29, Cole Robinson wrote:
> Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version
> string from:
> 
> QEMU PC Emulator version x.yy.z
> 
> to
> 
> QEMU Emulator version x.yy.z
> 
> libvirt is overly sensitive to the format of this string, and barfs when
> trying to parse qemu -help output. While libvirt should certainly be more
> robust here, changing the output format of -version for cosmetic reasons
> doesn't seem like the best idea, so let's revert the change and add a
> comment explaining the issue.

Rather than this, I would prefer a -version argument that just returns
the current QEMU version string.

IMHO it's not a good approach to do static string matching.

Cheers,
Jes



Reply via email to