On 4 September 2015 at 07:54, Pavel Fedin <p.fe...@samsung.com> wrote: > Hello! > >> > + >> > +#define kvm_gicd_access(s, offset, cpu, val, write) \ >> > + kvm_device_access(s->dev_fd, KVM_DEV_ARM_VGIC_GRP_DIST_REGS, \ >> > + KVM_VGIC_ATTR(offset, cpu), val, write) >> > + >> > +#define kvm_gicc_access(s, offset, cpu, val, write) \ >> > + kvm_device_access(s->dev_fd, KVM_DEV_ARM_VGIC_GRP_CPU_REGS, \ >> > + KVM_VGIC_ATTR(offset, cpu), val, write) >> >> Can you make these two static inline functions, not #defines, please? > > I can, of course, and i did in previous versions, but you disliked it > because inline functions would require dev_fd instead of 's', because > 's' is different in GICv2 and GICv3. Macro approach allowed to work > around this difference. Or do you mean you strictly don't want them > to be reusable?
Oh, right. In that case, yes, I don't think they're worth trying to share between the two devices. -- PMM
