Eric Blake <ebl...@redhat.com> writes: > We had some pointless differences in the generated code for visit, > command marshalling, and events; unifying them makes it easier for > future patches to consolidate to common helper functions. > > This is patch 3/4, focusing on naming the goto labels 'out' (not > 'clean') and 'out_obj' (not 'out_end'). Additionally, the generator > was inconsistent on whether labels had a leading space; prefer the > emacs style of including the space, so that only function names and > comments occur in column 1 of the generated file [HACKING gives no > preference, and both styles occur elsewhere in qemu.git].
Your Emacs prefers this? Mine doesn't. If I read CC Mode correctly, only style "gnu" does this. I use "stroustrup" for QEMU, because it's very close. It doesn't do this. As far as I can see, the only label we generate indented before this patch is qapi-event.py's clean. When in doubt, avoid the churn: we rename that one anyway, so let's drop the space there, and leave the others alone. > No change in semantics to the generated code. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > > --- > v6: split 9/46 into four patches, update docs where they are affected, > pick consistent spacing of label > > Signed-off-by: Eric Blake <ebl...@redhat.com>
