On 6 October 2015 at 00:17, Michael S. Tsirkin <m...@redhat.com> wrote: > On Mon, Oct 05, 2015 at 11:39:39PM +0100, Peter Maydell wrote: >> On 2 October 2015 at 14:45, Michael S. Tsirkin <m...@redhat.com> wrote: >> > Most people don't run make check by default, so they skip vhost-user >> > unit tests. Solve this by using tmpfs instead, unless hugetlbfs is >> > specified (using an environment variable). >> > >> > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> >> > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> >> >> Unfortunately I didn't notice before applying the pull, but this >> is breaking 'make check' on AArch64 host for me: >> >> TEST: tests/vhost-user-test... (pid=20205) >> Warning: path not on HugeTLBFS: /tmp/vhost-test-gRpbwl >> qemu-system-i386: -netdev vhost-user,id=net0,chardev=chr0,vhostforce: >> vhost-net support is not compiled in >> qemu-system-i386: -netdev vhost-user,id=net0,chardev=chr0,vhostforce: >> failed to init vhost_net for queue 0 >> >> Broken pipe >> FAIL: tests/vhost-user-test >> >> Probably reproducible on x86 if you configure with --disable-vhost-net, >> though I haven't tried that. >> >> Perhaps tests/vhost-user-test should be set up >> in tests/Makefile using >> check-qtest-i386-$(CONFIG_VHOST_USER) rather >> than CONFIG_LINUX ? >> >> I'd appreciate a quick fix, because this machine is in my set >> of systems I test all pullreqs on now... >> >> thanks >> -- PMM > > I think you are right, but just to be on the safe side, let's test > both for now. > > If this helps you, pls feel free to apply. > > I will look at cleaning this up later.
Yes, this fixes the test run on aarch64; I'll apply it to master. -- PMM
