On 14 October 2015 at 13:45, Alex Bennée <alex.ben...@linaro.org> wrote: > While looking I noticed we probably extract more than we need into attrs > considering the tableattrs is snarfed earlier. Maybe we should only do: > > attrs = extract64(descriptor, 2, 10) > | (extract64(descriptor, 52, 7) << 10); > > Or even: > > attrs = extract64(descriptor, 2, 10) > | (extract64(descriptor, 52, 3) << 10);
It seemed neater to grab all of the attribute bits, even the reserved ones. Otherwise we'll end up needing to change the code back later if a new attribute we care about is added. thanks -- PMM
