Hello! > Should the pci_dev be passed to kvm_arch_fixup_msi_route() as well? > Currently, the only implementer of this function (s390x) does not need > it; but it shouldn't hurt?
Yes, it shouldn't. I didn't pass it there exactly because of this reason. However, &kroute is also passed to this function, so setting ARM-specific data could be moved there. I mean this repeating sequence (see vITS RFC 4/6 - https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg07075.html): --- cut --- kroute.flags = kvm_msi_flags; if (kroute.flags & KVM_MSI_VALID_DEVID) { kroute.u.msi.devid = pci_requester_id(dev); } --- cut --- Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia
