On Mon, Oct 19, 2015 at 04:12:00PM -0600, Eric Blake wrote: > On 10/12/2015 05:14 AM, Daniel P. Berrange wrote: > > If the port in the SocketAddress struct is NULL, it can allow > > the kernel to automatically select a free port. This is useful > > in particular in unit tests to avoid a race trying to find a > > free port to run a test case on. > > > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > util/qemu-sockets.c | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > Right now, the qapi documents InetSocketAddress.port as mandatory. > Should we relax it to be optional, rather than special-casing the empty > string "" to mean no port?
Yep, I can change qapi-schema.json to mark it optional. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
