* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" <dgilb...@redhat.com> wrote: > > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > > > > Rework the migration thread to setup and start postcopy. > > > > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > Reviewed-by: Amit Shah <amit.s...@redhat.com> > > > > diff --git a/include/migration/migration.h b/include/migration/migration.h > > index aecf284..0586f8c 100644 > > --- a/include/migration/migration.h > > +++ b/include/migration/migration.h > > @@ -136,6 +136,9 @@ struct MigrationState > > /* Flag set once the migration has been asked to enter postcopy */ > > bool start_postcopy; > > > > + /* Flag set once the migration thread is running (and needs joining) */ > > + bool migration_thread_started; > > + > > /* bitmap of pages that have been sent at least once > > * only maintained and used in postcopy at the moment > > * where it's used to send the dirtymap at the start > > if you split it, we can already integrate the migration_thread_started. > > I would suggest to change the name to migration_thread_running, but you > are the native one here O:-)
Changed. > If you don't want to add this variable, I *think* we could use > MIGRATION_STATE_NONE with just some little rearangements of the code. > On the other hand, it could be racy :-( Yeh, it seemed simpler to have a nice simple bool. > Reviewed-by: Juan Quintela <quint...@redhat.com> > > > Split only or rename variable just if you consider it convenient. Renamed, not split. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
