On Tue, 27 Oct 2015 10:47:54 +0200
"Michael S. Tsirkin" <m...@redhat.com> wrote:
> TL;DR:
> This fixes virtio in a way transparent to guest.
> We should now be able to revert commits aa8580cd and df0acded19ec which worked
> around it in a way that's not transparent.
(...)
> Michael S. Tsirkin (6):
> virtio: introduce virtio_map
> virtio: switch to virtio_map
> virtio-blk: convert to virtqueue_map
> virtio-serial: convert to virtio_map
> virtio-scsi: convert to virtqueue_map
> virtio: drop virtqueue_map_sg
>
> include/hw/virtio/virtio.h | 3 +--
> hw/block/virtio-blk.c | 5 +----
> hw/char/virtio-serial-bus.c | 5 +----
> hw/scsi/virtio-scsi.c | 16 ++------------
> hw/virtio/virtio.c | 52
> +++++++++++++++++++++++++++++++++++----------
> 5 files changed, 46 insertions(+), 35 deletions(-)
Does not compile for me on s390:
/home/cohuck/git/qemu/hw/virtio/virtio.c: In function ‘virtqueue_map’:
/home/cohuck/git/qemu/hw/virtio/virtio.c:498:25: error: passing argument 3 of
‘virtqueue_map_iovec’ from incompatible pointer type [-Werror]
1);
^
/home/cohuck/git/qemu/hw/virtio/virtio.c:451:13: note: expected ‘size_t *’ but
argument is of type ‘unsigned int *’
static void virtqueue_map_iovec(struct iovec *sg, hwaddr *addr,
^
/home/cohuck/git/qemu/hw/virtio/virtio.c:501:25: error: passing argument 3 of
‘virtqueue_map_iovec’ from incompatible pointer type [-Werror]
0);
^
/home/cohuck/git/qemu/hw/virtio/virtio.c:451:13: note: expected ‘size_t *’ but
argument is of type ‘unsigned int *’
static void virtqueue_map_iovec(struct iovec *sg, hwaddr *addr,
^
