On 11/03/2015 08:50 PM, Paolo Bonzini wrote:
On 03/11/2015 18:42, Denis V. Lunev wrote:
There 2 small notes here:
- there is small patch with 'all' alias for all tracepoints which
could also be useful in the scope of this work:
[PATCH v2 1/1] allow to enable all tracepoints via alias all
- it would be great if patches from my log patchset will be merged.
I'll port them tomorrow on top of this set (if will not work on
findings in locking patchset)
Switch from inline call to #define and QMP/QAPI logging seems
really necessary. timestamp could be enabled or not but it is
better to use unified approach for logging timestamps and
tracing timestamps.
I think the "right" way would be to add tracepoints to the qmp_*
functions, or to make your logging a tracepoint. BTW, why are you not
logging QMP commands from the Virtuozzo management tool? That's what
libvirt is doing, you can find the JSON in qemu.log IIRC.
Paolo
because libvirt is maintained by the different team and
I have to find a way to prove the side of the problem ;)
OK. using tracepoint for this (after this patchset) could
be fine. Thank you for an idea, I'll elaborate this tomorrow.
Den
