On Sun, 23 May 2010 12:59:19 +0200
Jan Kiszka <jan.kis...@web.de> wrote:
> From: Jan Kiszka <jan.kis...@siemens.com>
>
> Allow to specify the device to be removed via device_del not only by ID
> but also by its full or abbreviated qtree path. For this purpose,
> qdev_find is introduced which combines walking the qtree with searching
> for device IDs if required.
[...]
> Arguments:
>
> -- "id": the device's ID (json-string)
> +- "path": the device's qtree path or unique ID (json-string)
>
> Example:
>
> --> { "execute": "device_del", "arguments": { "id": "net1" } }
> +-> { "execute": "device_del", "arguments": { "path": "net1" } }
Doesn't seem like a good change to me, besides being incompatible[1] we
shouldn't overload arguments this way in QMP as overloading leads to
interface degradation (harder to use, understand, maintain).
Maybe we could have both arguments as optional, but one must be passed.
[1] It's 'legal' to break the protocol before 0.13, but this has to be
coordinated with libvirt so we should have a good reason to do this
> <- { "return": {} }
>
> EQMP
