Am 16.11.2015 um 15:07 schrieb Andreas Färber: > Am 16.11.2015 um 15:05 schrieb Peter Maydell: >> Add a new optional method get_phys_page_attrs_debug to CPUClass. >> This is like the existing get_phys_page_debug, but also returns >> the memory transaction attributes to use for the access. >> This will be necessary for CPUs which have multiple address >> spaces and use the attributes to select the correct address >> space. >> >> We provide a wrapper function cpu_get_phys_page_attrs_debug() >> which falls back to the existing get_phys_page_debug(), so we >> don't need to change every target CPU. >> >> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> >> --- >> include/qom/cpu.h | 36 ++++++++++++++++++++++++++++++++++-- >> 1 file changed, 34 insertions(+), 2 deletions(-) > > Please use "qom:" and () by convention, otherwise looks fine.
Err, obviously I meant "cpu:". > > Regards, > Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)