"Michael S. Tsirkin" <m...@redhat.com> writes: > On Mon, Nov 23, 2015 at 09:35:31AM +0100, Markus Armbruster wrote: >> qmp_query_memdev() has two error paths: >> >> * When object_get_objects_root() returns null. It never does, so >> simply drop the useless error handling. >> >> * When query_memdev() fails. It leaks err then. But any failure >> there is actually a programming error. Switch it to &error_abort, >> and drop the useless error handling. >> >> Messed up in commit 76b5d85 "qmp: add query-memdev". >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > > Post 2.5 right?
I don't mind. I meant v1 for 2.5, but we've since convinced ourselves that errors can't happen, and the memory leak is only latent.
