Paolo Bonzini <pbonz...@redhat.com> writes: > On 30/11/2015 04:47, Peter Xu wrote: >> >> I met one problem when trying to add a new public function in dump.h >> named "dump_state_get_global" and using it in hmp.c. > > Don't do that. :) > > hmp.c functions should in general use the QMP commands as the base. In > your case, hmp_info_dump should call qmp_query_dump.
Yes. HMP commands need to be implemented on top of QMP commands, to avoid a feature gap. Exception: HMP commands that make no sense for QMP, like "print" or "cpu".
