On 12/03/2015 09:37 AM, Markus Armbruster wrote: > Since prop_get_fdt() is only used with QmpOutputVisitor, errors > shouldn't actually happen, so this is only a latent bug. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > hw/ppc/spapr_drc.c | 32 ++++++++++++++++++++++++++------ > 1 file changed, 26 insertions(+), 6 deletions(-)
I posted a similar patch, but using &error_abort rather than propagating, here: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg05788.html But I like yours better. > > diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c > index f34bc04..4e7a1d3 100644 > --- a/hw/ppc/spapr_drc.c > +++ b/hw/ppc/spapr_drc.c Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
