On 09/12/2015 20:57, Ashok Raj wrote: > + /* > + * We need to read back the value of MSREXT_MCG_CTL that was set by the > + * guest kernel back into Qemu > + */ > + cs->kvm_vcpu_dirty = false; > + cpu_synchronize_state(cs);
This should not be necessary. I've only skimmed the patches but, apart from this, the patches look good. Eduardo knows more than me about machine types and backwards compatibility to older kernels, however, and I'm deferring to him on this aspect. How was this tested? (In general, how do you test MCE? :)) Paolo