On Tue, 01 Jun 2010 15:19:59 +0200 Jan Kiszka <jan.kis...@siemens.com> wrote:
> Luiz Capitulino wrote: > > On Tue, 01 Jun 2010 15:09:34 +0200 > > Jan Kiszka <jan.kis...@siemens.com> wrote: > > > >> Luiz Capitulino wrote: > >>> Two bugs that might not be related to this thread: > >>> > >>> * "id" member is not mandatory for the device_add command: > >>> > >>> { "execute": "device_add", "arguments": { "driver": "e1000" } } > >>> {"return": {}} > >> Once we enable qtree paths for device_del, this is no longer an issue, > >> devices will remain addressable. > > > > Main point is whether "id" is required or not, I think it should be. > > And I think it might be recommended but should become mandatory > (specifically not for HMP). Maybe you meant 'should not'? Anyway, if we keep it optional for device_add we should also change the others _add commands to have the same behavior.