On Fri, Dec 11, 2015 at 08:22:59AM -0700, Eric Blake wrote:
> On 12/10/2015 05:11 PM, David Gibson wrote:
> > The functions for migrating the hash page table on pseries machine type
> > (htab_save_setup() and htab_load()) can report some errors with an
> > explicit fprintf() before returning an appropriate eror code. Change these
> > to use error_report() instead.
> >
> > Signed-off-by: David Gibson <da...@gibson.dropbear.id.au>
> > ---
> > hw/ppc/spapr.c | 17 +++++++++--------
> > 1 file changed, 9 insertions(+), 8 deletions(-)
> >
>
> >
> > @@ -1577,9 +1578,9 @@ static int htab_load(QEMUFile *f, void *opaque, int
> > version_id)
> > if ((index + n_valid + n_invalid) >
> > (HTAB_SIZE(spapr) / HASH_PTE_SIZE_64)) {
> > /* Bad index in stream */
> > - fprintf(stderr, "htab_load() bad index %d (%hd+%hd entries) "
> > - "in htab stream (htab_shift=%d)\n", index, n_valid,
> > n_invalid,
> > - spapr->htab_shift);
> > + error_report(
> > + "htab_load() bad index %d (%hd+%hd entries) in htab stream
> > (htab_shift=%d)\n",
> > + index, n_valid, n_invalid, spapr->htab_shift);
>
> No trailing newline to error_report().
Thanks. Changed that in most of the places I removed fprintf(), but
missed this one.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
