On 15 December 2015 at 14:28, Paolo Bonzini <pbonz...@redhat.com> wrote: > These patches are perhaps the only somewhat controversial part. > Generally, we add opaque typedefs to typedefs.h in order to avoid > indirect header inclusions. However, this might not be desirable > for target specific types such as FooCPU. These types are used > mostly in headers for boards, and thus this series uses struct > explicitly in those headers. Adding a typedef breaks on older > compilers that do not like redefinitions of typedefs.
I would prefer us to provide the typedef. There's no problem with older compilers because you just only define the typedef in one place (typically in typedefs.h). thanks -- PMM
