Am 02.06.2010 18:16, schrieb Markus Armbruster: > Kevin Wolf <kw...@redhat.com> writes: > >> Am 02.06.2010 13:31, schrieb Markus Armbruster: >>> Anything that moves hundreds of lines out of vl.c can't be all bad. >>> >>> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> >> New files need a license header, otherwise it looks ok. >> >> I have applied this patch (and the other ones, too) to the block branch >> anyway to avoid conflicts with other people basing their patches on that >> branch. However, it requires a v2 before I can propose this to be merged >> into master. > > vl.c has "Copyright (c) 2003-2008 Fabrice Bellard". monitor.c has > "Copyright (c) 2003-2004 Fabrice Bellard". Would the following header > do? > > /* > * QEMU host block devices > * > * Copyright (c) 2003-2008 Fabrice Bellard > * > * This work is licensed under the terms of the GNU GPL, version 2 or > * later. See the COPYING file in the top-level directory. > */
Should be good enough, I think. vl.c and monitor.c are BSD licensed, though. Not sure if anyone minds if the license is changed to GPL. Probably not, just want to have it mentioned. Kevin
